Re: Squid-ICAP problem (bug?)

Hi,
I send this mail from un account which is not subscribed to the mailing
list so I am re-sending it. Sory about that.
Please to the mailing list moderator to ingore the first mail.
-------------

Hi Christophe,
  First of all squid3 has a better support for icap protocol now.
Maybe it is better to use squid3 as icap client.

   However, yes the problem looks that exists in squid25-icap and
squid26-icap.
In fle icap_reqmod.c, in function icapReqModReadHttpBody near line
878-880 try this small patch :

- if (icap->reqmod.http_entity.bytes_read >=
icap->request->content_length)
- icap->flags.reqmod_http_entity_eof = 1;
+ // if (icap->reqmod.http_entity.bytes_read >=
icap->request->content_length )
+ if (icap->chunk_size < 0 )
+ icap->flags.reqmod_http_entity_eof = 1;

It must marks the http_entity_eof when it has read the "0\r\n\r\n" chunk.
Works for me but I did not test it enough....

Regards,
        Christos

Christophe Boyanique wrote:
>
> Hello,
>
> I think I have found a bug in the Squid-ICAP patch and I would like to
> have your opinion about it.
>
> I use a tcpdump strace and verbose log to track a problem which occurs
> sometimes during a respmod request but is triggered during the reqmod
> answer analysis I think.
>
> We use squid-2.5.STABLE14 and Squid-Icap patch from 2006/06/26.
>
> .....................
Received on Thu Nov 09 2006 - 05:33:47 MST