Re: Squid 2.6 MinGW support patch for review

On Monday 04 September 2006 22:29, Guido Serassio wrote:
> Hi Henrik,
>
> At 09.09 04/09/2006, Henrik Nordstrom wrote:
> >mån 2006-09-04 klockan 09:03 +0200 skrev Guido Serassio:
> >
> > > They are needed by the FD<=> socket "magic" in
> > > squid_mswin.h, I need to know when I'm compiling these files.
> >
> >Ok. Then drop the #if / #endif, keeping only the #define and add a
> >comment.
> >
> >The way it's done now looks like #include shielding, which it isn't.
>
Actually it is #include shielding providing a clean output during
compile.
It prevents them from being accidentally defined twice and giving a gcc
warning - ... previously defined here ...

Therefore isn't it technically correct ?

-- 
regs conon
_______________________
\                      \
 \   OOHH I hate TYPOS  \
  \                      \
   ~~~~~~~~~~~~~~~~~~~~~~~~