Re: Small patch for SCO systems

On Sun, 13 Nov 2005, Kean Johnston wrote:

> Hi,
>
> Attached is a small patch for getting things working on SCO OpenServer.
>
> Here is a hand-typed (i.e not done in emacs) ChangeLog entry:
>
> 2005-11-13 Kean Johnston <jkj@sco.com)
> * configure.in: Only check for -lintl on old SCO systems.

ok I suppose.. What I don't quite get is why are we even checking for it
in the first place...

> Dont remove -O for gcc 2.95.3 on SCO OpenServer.

Are you sure? We don't have much trust in those GCC versions... I no
longer remember the exact conditions when this GCC optimization bug was
discovered but I think it was a generic X86 bug, not tied to a specific OS
platform..

The -O flag does not make that big difference for Squid. If in any doubt
on the compiler quality it's recommended not to use it..

> Add check fot setenv as not all systems have it.

Already fixed by using putenv instead.

> Include syslog.h when checking for the syslog function.

good I suppose.

> Remove extraneous libraries for OpenServer 5.

good.

>
> * lib/rfc1035: Include <string.h> if the system has it,
> as that is wher strtok is declared.

right.

> * src/cache_cf: Only call setenv if the host has it.

Already fixed by using putenv instead.

> * src/pinger.c: SCO OpenServer provides in_cksum, so dont
> need local copy (it causes conflicts).

ok.

> * src/squid.h: Compare SQUID_MAXFD to FD_SETSIZE, not
> DEFAULT_FD_SETSIZE, as it is the former that is used during
> compilation, not the latter.

FD_SETSIZE is NOT available at this point in the header file. Only after
the system headers have been included at which point it's too late to
override the system defaults.

DEFAULT_FD_SETSIZE is the FD_SETSIZE detected by configure, and is
available here via autoconf.h.

The purpose of this check is to see if Squid needs to override FD_SETSIZE
by defining it before including the system headers, or if the system
default FD_SETSIZE is sufficient.

Regards
Henrik
Received on Mon Nov 14 2005 - 08:15:16 MST