Re: squid3 PRE1 ?

On Mon, 2003-04-21 at 22:31, Henrik Nordstrom wrote:
> On Monday 21 April 2003 11.08, Guido Serassio wrote:
>
> > OK, but the next patch to win32.cc will be huge because contains
> > all the win32 specific service code.
>
> The size of a given patch does not indicate how troublesome the patch
> is.
...
>
> Note: In terms of places modified less is not necessarily better than
> more. If a patch needs to make modifications to existing code for
> best overall quality then it should. Trying to limit the amount of
> existign code modified at the expense of the quality of the added
> code is not acceptable as a design goal.

In addition to what Henrik said with regard to patch easiness:

A patch that has a single goal is much easier to review / apply / tweak
than a patch that does many things. It doesn't matter how big it is if
it follows the guideline of having a single goal. (Usually that
guideline results in small patches, but not always).

Your split out patches for instance, with one small goal per patch are
really easy to review, and thus apply.

Rob

-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.