Re: Windows port merge - Service support (part 1) [PATCH]

Hi Henrik,

Il 15.17 21/04/2003 Henrik Nordstrom ha scritto:

>On Monday 21 April 2003 12.24, Guido Serassio wrote:
>
> > - main.cc and protos.h: changed rotate_logs() and reconfigure()
> > from static to global (needed by service functionality), added
> > Windows platform info in cache.log
>
>Another minor unrelated change in main.cc (but correct in context of
>prior patches) opened a question on the integration of the nt port:
>
>Exacly when is _SQUID_MSWIN_ defined?

Only when building Squid in Windows native mode using MinGW or MS Visual
Studio.

>If this is also defined when building using CYGWIN then the windows
>port is perhaps a bit too intrusive in how/why it removes the daemon
>mode of Squid. Probably this should be wrapped into a #ifdef
>DAEMON_MODE instead, defined accordingly.

The daemon mode is removed only when Squid is build on Cygwin or native
mode with USE_WIN32_SERVICE defined (a new configure option
--enable-win32-service is defined to enable this, but still to be merged).
When this happens, the Windows service functionality replace the daemon mode.

So using --enable-win32-service at configure time on Cygwin, Squid can be
build in "standard mode" (cmd line + daemon mode) or "Windows mode" (cmd
line + service mode)

On MinGW or MS Visual Studio the daemon mode is always not available.

Regards

Guido

>If you want to remove a feature then my preference is to add a
>conditional define (and maybe even a configure option) for this
>specific feature rather than relying on hardcoded platform defines.
>
>Regards
>Henrik

-
=======================================================
Serassio Guido
Via Albenga, 11/4 10134 - Torino - ITALY
E-mail: guido.serassio@serassio.it
WWW: http://www.serassio.it
Received on Mon Apr 21 2003 - 07:40:54 MDT