Re: Windows port merge - MS Visual C++ compatibility [PATCH]

Hi Robert,

Il 09.13 11/03/2003 Robert Collins ha scritto:

>On Tue, 2003-03-11 at 07:30, Guido Serassio wrote:
>
> > >Is there anyway we can avoid the whole file #ifdefs in VS ? I'm applying
> > >this anyway, but as we get more modular, this is going to
> > >become....annoying.
> >
> > Now on MS Visual Studio I'm using a manually changed autoconf.h with a
> > monolitich workspace, I don't have better ideas, but if someone propose
> > something more simple, I'm happy too ...
>
>libxml2 and libxslt have a jscript based build system - they found
>visual studio to cumbersome... you might want to investigate that. (Only
>if you have time - I don't *need* you to change - we can accomodate a
>monolithic build system for quite some time).

OK, in future, when there are no more big problems in the build process, we
can take a look to this.

> > >Can you enlarge on the TOS casts? They are going to affect all
> > >platforms, I need to know what they are meant to achieve (i.e. why the
> > >compilers implicit casting isn't enough).
> >
> > MS Visual C++ is not happy without this cast, and from protos.h I can see:
> >
> > SQUIDCEXTERN int comm_openex(int, int, struct in_addr, u_short, int,
> > unsigned char TOS, const char *);
> >
> > so I don't see something of strange on casting TOS to unsigned char.
>
>Well, you cast it several timesm to different types in that patch, and
>the returned value from get..Tos is (IIRC) int. So, I'm trying to
>understand why:
>* we don't change the return type of the getTos routines.

Interesting question.

Regards

Guido

-
=======================================================
Serassio Guido
Via Albenga, 11/4 10134 - Torino - ITALY
E-mail: guido.serassio@serassio.it
WWW: http://www.serassio.it
Received on Tue Mar 11 2003 - 03:34:04 MST