Re: squid-3 buglet: stack trace

From: Robert Collins <robertc@dont-contact.us>
Date: 07 Mar 2003 07:38:37 +1100

On Fri, 2003-03-07 at 04:05, Adrian Chadd wrote:
> On Thu, Mar 06, 2003, Henrik Nordstrom wrote:
> > > (gdb)
> > >
> > > hm. I don't remember ever doing that. :) I'll take a squizz in a tick.
> >
> >
> > cbdataReferenceDone missing from ConnStateData::~ConnStateData I think..
> >
>
> I'll leave it for robert to look at tomorrow morning (thismorning. :)
> That way he can go "no, I need a delete here, a new here and some friend
> stuff and it is all good!" to fix it, and I'll just feign ignorance for now. :)

Bah!

Seriously, for the C++ impeded :]. In squid3 we *can* use all the squid2
idioms but hey also have replacements:

In squid-2:
memPoolAlloc + set variables OR
cbdataAlloc + set variables OR
x[c|m]alloc + set variables

in squid-3:
new Foo(parameters) OR
new Foo OR
new Foo + set variables
===
in squid-2:
cleanup + cbdataFree OR
cleanup + memPoolFree OR
clenaup + [x|safe_]free

in squid-3:
Foo->deleteSelf();
===
in squid-2:
cbdataFree + a cbdataFreeHandler

in squid-3:
inherit from RefCountable, and just set the pointer to NULL:
aFooPointer = NULL;

Rob

-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.

Received on Thu Mar 06 2003 - 13:38:43 MST

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:19:31 MST