Re: doctype declaration

----- Original Message -----
From: Henrik Nordstrom <hno@marasystems.com>
Date: Wed, 17 Jul 2002 16:03:00 +0200
To: "PsychoTekk .de" <psychotekk@europe.com>, squid-dev@squid-cache.org
Subject: Re: doctype declaration

> What I am mainly missing now is the needed HTTP charset support patch.

i actually have no idea of c programming, i just know vb and perl
and thus understand the most important things.
in addition to that the source files are mostly .c and .h files, and
i'm using ms visual studio 6.0 which requires additional files to
open the project as a project.
however, here are some thoughts:

many of the error documents (e.g. the bulgarian ones) already
contain the http-equiv meta tag to set a specific charset,
others have no characterset specified at all.

i suggest to add default_err_charset to squid.conf, e.g.
default_err_charset iso-8859-1
(which would be read like this: Config.default_err_charset
from the .c files ?)
that is added to errorpage.c's errorBuildReply() function:
instead of
"text/html",
"text/html" + "; charset=" + Config.default_err_charset
is set in httpReplySetHeaders(), so that the header would look like
this:
Content-Type: text/html; charset=iso-8859-1

for those err documents that already contain a meta tag it needs
to be parsed (sorry, i have no idea how this is done in c),
and this parsed charset must override the default charset specified
in squid.conf.

================================================================

besides that, here is the HTML-patch:
http://www.psychotekk.de/extern/html.diff
(i also set the w flag because my editor automatically
cut away the white space at the end of the lines of
all documents i edited, and i did not want to make
the patch file unnecessarily large. if this is a problem
let me know and i will provide a ru - only version)

- it contains further err document fixes
  (the polish err docs contained closing </body>
  and </html> tags)
- i translated some err documents in the german folder
  that were still in english language
- all html docments generated and used by squid
  or cachemgr now contain a doctype declaration,
  a style (background-color white, font verdana),
  and are valid according to the standards at www.w3.org
  (i could of course not check back each and every err doc
  but from what i have seen it should be okay).
  the modified .c files were:
  cachemgr.c,
  errorpage.c,
  ftp.c,
  gopher.c and
  urn.c

regards,
 C.L:

-- 
__________________________________________________________
Sign-up for your own FREE Personalized E-mail at Mail.com
http://www.mail.com/?sr=signup


Save up to $160 by signing up for NetZero Platinum Internet service.
http://www.netzero.net/?refcd=N2P0602NEP8