RE: [Squid-cvs] ntlm squid/src authenticate.c,1.1.1.3.12.57,1.1.1.3.12.58

> -----Original Message-----
> From: Henrik Nordstrom [mailto:hno@marasystems.com]
> Sent: Thursday, 13 June 2002 3:49 AM
> To: Robert Collins; squid-dev@squid-cache.org
> Subject: Re: [Squid-cvs] ntlm squid/src
> authenticate.c,1.1.1.3.12.57,1.1.1.3.12.58
>
>
> Nice to see you around again ;-)

Thanks, hopefully I'll have a bit more time in the near future. More on
that later.
 
> This you shouldn't need to do at all.. memPoolAlloc returns
> zeroed memory..
>
> Data returned by memPoolAlloc is only unclean if the entry has been
> (incorrecly) used after free or other kinds of memory corruption.

Hmm, it could be use-after-free I suppose, but it didn't look like it.
It took Kinkie and I about 4 hours of unpleasant debugging to isolate
the returned memory as being wrong.

All the use of that struct is done via reference counted locks, so I'm
fairly confident that it won't be getting accessed after free. Sigh. I
can't offer to review the code properly just now either...

Rob
Received on Wed Jun 12 2002 - 14:26:38 MDT