RE: squid-2.4 ?

> -----Original Message-----
> From: Henrik Nordstrom [mailto:hno@squid-cache.org]
> Sent: Thursday, February 14, 2002 12:12 PM
> To: Robert Collins
> Cc: Squid Developers Mailinglist
> Subject: Re: squid-2.4 ?
>
>
> On Thursday 14 February 2002 00.08, Robert Collins wrote:
>
> > > I also think 2.5-PRE4 is a STABLE candidate.
> >
> > There's a mem leak somewhere in the ntlm/persistent connection
> > code. It won't affect non-NTLM users.
>
> Confirmed. It is leaking a lot there.. a couple of hundred bytes per
> connection or more.
>
> The first is easy to fix. Simply free the data after being logged.
> Hmm.. I wonder why I haven't seen this leaking before.. have you
> changed this recently? I have a strong memory of having run Squid
> with Basic authentication and leak testing without seeing this, and
> as far as I can tell it is not NTLM specific..

No recent changes, no. > 6 months IIRC.
 
> The second I am not entirely sure about. Think the strdup should be
> taken out of there, but you know the auth code better. The following
> seems to work here:

I'll review tonight.

Rob
Received on Wed Feb 13 2002 - 18:23:34 MST