Re: NTLM code question

----- Original Message -----
From: "Henrik Nordstrom" <hno@marasystems.com>
To: <squid-dev@squid-cache.org>
Sent: Friday, September 28, 2001 5:48 PM
Subject: NTLM code question

> While going thru the cbdata branch, my eyes fell on the following:
>
> ntlm_auth.c:authenticateNTLMHandleplaceholder
>
> /* standard callback stuff */
> valid = cbdataValid(r->data);
> if (!valid) {
> debug(29, 1) ("AuthenticateNTLMHandlePlacheholder: invalid
> callback data.\n");
> return result;
> }
> /* call authenticateNTLMStart to retry this request */
> debug(29, 9) ("authenticateNTLMHandleplaceholder: calling
> authenticateNTLMStart\n");
> authenticateNTLMStart(r->auth_user_request, r->handler, r->data);
> cbdataDone(r->data);
> authenticateStateFree(r);
> return result;
>
>
> Shouldn't the above error case free up things? Seems a bit odd to only
> return, not freeing the cbdata or auth state.

Ah, yes.

Rob
Received on Sat Sep 29 2001 - 03:56:03 MDT